From 1c7964a1ea4b2f46958fdc716c7b9a06f5514fab Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Mon, 28 Oct 2013 11:58:44 +0100 Subject: [PATCH] common/initcall: extern linker symbols with correct types Coverity IDs 1054956, 1054957 Coverity pointed out that we applying array operations based on an expression which yielded singleton pointers. The problem is actually that the externs were typed incorrectly. Correct the extern declaration to prevent straying into undefined behaviour, and relying on the lenience of GCC to work. Signed-off-by: Andrew Cooper Acked-by: Keir Fraser --- xen/common/kernel.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index b8707d90a1..4ca50c4d92 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -196,19 +196,20 @@ void add_taint(unsigned flag) tainted |= flag; } -extern initcall_t __initcall_start, __presmp_initcall_end, __initcall_end; +extern const initcall_t __initcall_start[], __presmp_initcall_end[], + __initcall_end[]; void __init do_presmp_initcalls(void) { - initcall_t *call; - for ( call = &__initcall_start; call < &__presmp_initcall_end; call++ ) + const initcall_t *call; + for ( call = __initcall_start; call < __presmp_initcall_end; call++ ) (*call)(); } void __init do_initcalls(void) { - initcall_t *call; - for ( call = &__presmp_initcall_end; call < &__initcall_end; call++ ) + const initcall_t *call; + for ( call = __presmp_initcall_end; call < __initcall_end; call++ ) (*call)(); } -- 2.30.2